argoproj / argoproj/argo-workflows
Enable linting for `kmsId` and `nodeId` fields
- Dominant language
- Go
- Stars
- 17k
- Forks
- 3.7k
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 138
Description
# Summary
`kmsId` and `nodeId` fields are excluded from linting (ST1003) since this change affects generated files (like `proto` and `swagger`) and is a breaking change. Also, changing these files adds new entries to `pkg/apis/api-rules/violation_exceptions.list`.
For more info, check:
- https://github.com/argoproj/argo-workflows/pull/14520/files#diff-94d0f1284fafd0a1cb05dc2309b4be043b6fb01d66626ab1867d40c84b573ec2L1367
- https://github.com/argoproj/argo-workflows/pull/14520/files#diff-94d0f1284fafd0a1cb05dc2309b4be043b6fb01d66626ab1867d40c84b573ec2L2592
- https://github.com/argoproj/argo-workflows/pull/14520
## Use Cases
Just code and style improvements.
---
**Message from the maintainers**:
Love this feature request? Give it a 👍. We prioritise the proposals with the most 👍.
Contributor guide
Research direction
Review the linked PR #14520 and its referenced changes to understand how `kmsId` and `nodeId` are excluded from ST1003 linting. Check the generated proto and Swagger files and `pkg/apis/api-rules/violation_exceptions.list` mentioned in the issue. Done means the fields are linted without unintended generated-file changes or new violation exceptions; confirm the breaking-change implications before proceeding.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100