argoproj / argoproj/argo-workflows

UI configurable list limit on cronworkflow detail page

Open
#14,065 3 comments 2 reactions 1 assignee Claimed by @ajayrajsaini View on GitHub
area/ui good first issue
Dominant language
Go
Stars
17k
Forks
3.7k
Avg merge
1d 20h
Merged PRs (30d)
138

Description

# Summary

What change needs making?

When visiting cronworkflow detail, e.g. `cron-workflows/argo/test-cron-wf`
The ui will do a List workflow request to list the historical runs from this cronworkflow.
However, this list limit is hardcoded to 50 instead of configurable like workflows page.

example request
`http://localhost:8080/api/v1/workflows/argo?listOptions.labelSelector=workflows.argoproj.io/cron-workflow=test-cron-wf&listOptions.limit=50&fields=metadata,items.metadata.uid,items.metadata.name,items.metadata.namespace,items.metadata.creationTimestamp,items.metadata.labels,items.metadata.annotations,items.status.phase,items.status.message,items.status.finishedAt,items.status.startedAt,items.status.estimatedDuration,items.status.progress,items.spec.suspend`

## Use Cases

When would you use this?

We want to be able to configure this list limit, either a default list limit or a parameter we can change on the UI.
So that if each workflow is huge, we can use a smaller limit to save the amount of memory needed for server, and not having it OOM,

---

**Message from the maintainers**:

Love this feature request? Give it a 👍. We prioritise the proposals with the most 👍.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.