argoproj / argoproj/argo-workflows
Deprecate retrying of failed nodes by default.
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 17k
- Forks
- 3.7k
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 138
Description
# Summary
Currently a user might have a `continueOn: failed` or `depends: $TASKNAME.Failed` and they might consider this node to have succeeded from their point of view (In the sense that the failure is no big deal or that it was expected).
Currently the retry logic attempts to reset these nodes, which is an introduction of policy that is forced upon the user.
We should in the very least be able to opt out of this behaviour.
## Use Cases
This allows one to precisely retry a single node without worrying about a failed node also retrying.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the retry logic for nodes using `continueOn: failed` or `depends: $TASKNAME.Failed`. Determine how an opt-out and the proposed default behavior should interact with single-node retries, then add coverage showing that expected failures are not reset unless explicitly requested.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend, distributed-systems
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100