argoproj / argoproj/argo-workflows

set `WatchListPageSize` when `WatchError`

Open
#13,461 2 comments 0 reactions 0 assignees View on GitHub
area/controller
Dominant language
Go
Stars
17k
Forks
3.7k
Avg merge
1d 20h
Merged PRs (30d)
138

Description

### Pre-requisites

- [X] I have double-checked my configuration
- [X] I have tested with the `:latest` image tag (i.e. `quay.io/argoproj/workflow-controller:latest`) and can confirm the issue still exists on `:latest`. If not, I have explained why, **in detail**, in my description below.
- [X] I have searched existing issues and could not find a match for this bug
- [x] I'd like to contribute the fix myself (see [contributing guide](https://github.com/argoproj/argo-workflows/blob/main/docs/CONTRIBUTING.md))

### What happened? What did you expect to happen?

This submission is an optimization based on this https://github.com/argoproj/argo-workflows/pull/11343
Optimize two key points:

1. Only set to empty when resourceVersion = 0
2. Set the WatchListPageSize property to ensure pagination
### Version(s)

3.4.9

### Paste a minimal workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

```YAML
None
```

### Logs from the workflow controller

```text
None
```

### Logs from in your workflow's wait container

```text
None
```

Contributor guide

Open the contributing guide

Research direction

Locate the Go watch-error handling and compare it with PR #11343, focusing on the resourceVersion condition and WatchListPageSize. Verify the relevant behavior: the value is cleared only when resourceVersion is 0, and watch-list requests use WatchListPageSize for pagination.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.