argoproj / argoproj/argo-workflows
Enable PodGC for the agent pod
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 17k
- Forks
- 3.7k
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 138
Description
Summary
The agent pod will be deleted once the workflow is completed. I want it can follow the PodGC strategy, see https://github.com/argoproj/argo-workflows/pull/12679#issuecomment-1956205605
When we use OnWorkflowSuccess PodGC strategy, do not delete the agent pod if workflow fails, and deleteDelayDuration in PodGC shoud also takes effect.
Use Cases
I want use Plugin/HTTP templates, but there are some ability deficiencies.
For example, the agent pod logs are not saved (See #10647) and it is deleted once the workflow is completed.
This makes it impossible for us to troubleshoot this type of workflow at all.
Love this enhancement proposal? Give it a 👍. We prioritize the proposals with the most 👍.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the PodGC strategy discussion in PR #12679 and the agent-pod behavior described here; compare OnWorkflowSuccess and deleteDelayDuration when a workflow fails. Check the existing Plugin/HTTP template implementation and issue #10647, then add coverage showing failed workflows retain the agent pod and delayed deletion is honored.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, kubernetes
- Domain
- infrastructure
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100