argoproj / argoproj/argo-rollouts
Add ConsecutiveFailureLimit to AnalysisTemplate/ClusterAnalysisTemplate
- Dominant language
- Go
- Stars
- 3.6k
- Forks
- 1.2k
- Avg merge
- 2d 14h
- Merged PRs (30d)
- 28
Description
# Summary
Analysis templates currently support passing the analysis after N consecutive successes and/or failing after N total failures.
We'd love the ability to fail after N consecutive failures as well.
# Use Cases
This would be used to minimize "false positive" rollbacks, in cases where the metric that underlies the analysis may be slightly flaky. Requiring consecutive failures would give more confidence that something was actually wrong, rather than the system responding to a blip.
---
**Message from the maintainers**:
Need this enhancement? Give it a 👍. We prioritize the issues with the most 👍.
Contributor guide
Research direction
Start by locating the AnalysisTemplate and ClusterAnalysisTemplate definitions and the existing consecutive-success and total-failure handling. Add the requested consecutive-failure limit to both template types, then verify that tests cover failing only after the configured number of consecutive failures.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, kubernetes
- Domain
- devops, infrastructure
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100