argoproj / argoproj/argo-cd

Allow modification of pod annotations to HaProxy

Open
#21,995 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Go
Stars
24.2k
Forks
7.9k
Avg merge
1d 6h
Merged PRs (30d)
239

Description

Summary

Allow modification of pod annotations to haProxy

Motivation

cluster-autoscaler fails to evict a node because haProxy has localStorage present

I0225 09:05:41.542301 1 cluster.go:159] node ip-10-1-39-213.eu-west-2.compute.internal cannot be removed: pod with local storage present: argocd-redis-ha-haproxy-65fbc8f779-42nmn

Proposal

haproxy:
  podAnnotations: {}

This will allow us to set the annotation

cluster-autoscaler.kubernetes.io/safe-to-evict: "true"

notes:

setting the global.podAnnotations does not have any affect on ha-proxy pods.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Start by locating the Helm chart values and HAProxy pod template associated with global.podAnnotations, then trace how the proposed haproxy.podAnnotations value would reach those pods. Done means the safe-to-evict annotation can be configured specifically on HAProxy pods.

Written by the indexing model from the issue text.

Assessment

Tech stack
helm, kubernetes
Domain
devops, infrastructure
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.