argoproj / argoproj/argo-cd

Make `enable-new-git-file-globbing=true` the default and only option

Open
#14,101 5 comments 8 reactions 0 assignees View on GitHub
contributions-wanted enhancement
Dominant language
Go
Stars
24.2k
Forks
7.8k
Avg merge
1d 11h
Merged PRs (30d)
233

Description

# Summary

Make `enable-new-git-file-globbing=true` the only behavior. It's more consistent with our other globbing uses. https://github.com/argoproj/argo-cd/pull/13314

# Motivation

It's more intuitive. Using just the new globbing format will also eliminate one use of the `git` CLI, moving us further towards being able to go distroless.

# Proposal

Delete the code that did it the old way, leave the code that does it the new way.

Contributor guide

Open the contributing guide

Research direction

Start by locating the old and new Git file-globbing implementations, then review the behavior described in pull request #13314. Run the relevant tests and verify that only the new globbing behavior remains and the old Git CLI path is removed.

Written by the indexing model from the issue text.

Assessment

Tech stack
git, go
Domain
ci-cd, devops, tooling
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.