arduino / arduino/cpp-test-action
Add configuration flag to allow running the tests with valgrind
- Dominant language
- No language data
- Stars
- 19
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
### Describe the request
As pointed out by @tttapa over [here](https://github.com/arduino/ArduinoCore-API/pull/193#issuecomment-1666995795) we can not enable address sanitizers since `valgrind` in `CMakeLists.txt` would refuse to run it. Consequently it would be desirable to have a configuration flag that would allow to disable using valgrind for running the tests.
### Describe the current behavior
`arduino/cpp-test-action` always uses `valgrind` when running the unit tests, though there are situations where this may be not sensible to do.
### 'arduino/cpp-test-action' version
main
### Additional context
_No response_
### Issue checklist
- [X] I searched for previous requests in [the issue tracker](https://github.com/arduino/cpp-test-action/issues?q=)
- [X] I verified the feature was still missing when using the latest version
- [X] My request contains all necessary details
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with CMakeLists.txt and the cpp-test-action test-running entry point to trace where valgrind is always invoked. Add a configuration flag that skips valgrind while preserving unit-test execution, then verify the default behavior and the disabled-valgrind path.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c, cmake, cpp, github-actions
- Domain
- ci-cd, testing
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100