arduino / arduino/BasicEducationShield

pitches.h in main library

Open
#2 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
C++
Stars
6
Forks
11
PR merge metrics
No merged PRs in 30d

Description

I propose having pitches.h in the main library, so they can be used in any sketch without the need of including an extra file in the sketch folder.

Also, it's necessary for the sound effects to work. See commit [1e1a8520f58fa192efd449efe2ce77e96c21251a](https://github.com/arduinoverkstad/BasicEducationShield/commit/1e1a8520f58fa192efd449efe2ce77e96c21251a)

Contributor guide

No contributing guide indexed for this repository

Research direction

Inspect the library layout and the existing pitches.h referenced by the issue, then review commit 1e1a8520f58fa192efd449efe2ce77e96c21251a to understand how sound effects use it. Done means sketches can use the pitch definitions without copying an extra file, and the sound effects described in that commit work.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
embedded-iot
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.