arduino / arduino/ArduinoCore-samd
Serial buffer size unchangeable
- Dominant language
- C
- Stars
- 502
- Forks
- 740
- PR merge metrics
- No merged PRs in 30d
Description
Per https://github.com/arduino/ArduinoCore-samd/pull/651#issuecomment-1492773652.
Due to the `#undef` construct done in
https://github.com/arduino/ArduinoCore-samd/blob/a5d52dbf7bcf338de2042eb74cfba33993729c81/cores/arduino/Uart.h#L25-L29
it's not possible to set a global `-DSERIAL_BUFFER_SIZE=...` value and have it be use used anymore.
A user has a usecase for that [here](https://community.platformio.org/t/serial-buffer-size-on-grand-central-m4/32991).
Contributor guide
No contributing guide indexed for this repository
Research direction
Start in cores/arduino/Uart.h at lines 25-29 and inspect how the #undef construct affects SERIAL_BUFFER_SIZE. Verify that a global -DSERIAL_BUFFER_SIZE value is honored for the serial buffer, using the linked issue context and PlatformIO use case to check the expected behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- embedded-iot
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100