arduino / arduino/ArduinoCore-samd

variant/mkrnb1500 SARA R410 UART not configured to utilize flow control (RTS/CTS)

Open
#689 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
502
Forks
740
PR merge metrics
No merged PRs in 30d

Description

the schematic of the MKRNB1500 includes support for flow control (RTS/CTS) between the samd21 and the ublox SARA r410 modem.

Screen Shot 2022-12-22 at 08 02 19

when looking at the implementation; the Serial UART fails to include the flow control lines, when the GSM 1400 does

```
variant/mkrnb1500/variant.cpp
// SerialSARA
Uart Serial2(&sercom4, PIN_SERIAL2_RX, PIN_SERIAL2_TX, PAD_SERIAL2_RX, PAD_SERIAL2_TX);

void SERCOM4_Handler()
{
Serial2.IrqHandler();
}

variant/mkrgsm1400/variant.cpp
// SerialGSM
Uart Serial2(&sercom4, PIN_SERIAL2_RX, PIN_SERIAL2_TX, PAD_SERIAL2_RX, PAD_SERIAL2_TX, PIN_SERIAL2_RTS, PIN_SERIAL2_CTS);

void SERCOM4_Handler()
{
Serial2.IrqHandler();
}
```

to enable flow-control; the SerialSARA (Serial2) definition simply needs to be updated:

```
variant/mkrnb1500/variant.cpp
// SerialSARA
- Uart Serial2(&sercom4, PIN_SERIAL2_RX, PIN_SERIAL2_TX, PAD_SERIAL2_RX, PAD_SERIAL2_TX);
+ Uart Serial2(&sercom4, PIN_SERIAL2_RX, PIN_SERIAL2_TX, PAD_SERIAL2_RX, PAD_SERIAL2_TX, PIN_SERIAL2_RTS, PIN_SERIAL2_CTS);

void SERCOM4_Handler()
{
Serial2.IrqHandler();
}
```

Contributor guide

No contributing guide indexed for this repository

Research direction

Open variant/mkrnb1500/variant.cpp and compare the SerialSARA Serial2 definition with the corresponding SerialGSM definition in variant/mkrgsm1400/variant.cpp. Confirm the MKRNB1500 UART uses its defined RTS and CTS pins, then build the SAMD core or run the repository's available checks to verify the change.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
embedded-iot
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.