arduino / arduino/ArduinoCore-renesas
Code Review - Please remove this from code
Open
topic: code
type: enhancement
- Dominant language
- C
- Stars
- 193
- Forks
- 112
- PR merge metrics
- No merged PRs in 30d
Description
This should be removed from code. Don't mix macros and C++. This code cannot pass my internal code review check.
https://github.com/arduino/ArduinoCore-renesas/blob/1169821e942f2618336b51e7a76be2be7c68f9ba/libraries/Arduino_LED_Matrix/src/Arduino_LED_Matrix.h#L144
Contributor guide
No contributing guide indexed for this repository
Research direction
Open libraries/Arduino_LED_Matrix/src/Arduino_LED_Matrix.h at line 144 and inspect the referenced code in context, focusing on the stated macro and C++ mixing concern. Confirm the exact code to remove and verify that the Arduino LED Matrix library still builds correctly afterward.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- embedded-iot
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100