arduino / arduino/ArduinoCore-renesas

Implement SerialUSB::end

Open
#373 0 comments 0 reactions 0 assignees View on GitHub
topic: code type: imperfection
Dominant language
C
Stars
193
Forks
112
PR merge metrics
No merged PRs in 30d

Description

The `_SerialUSB::end` function is not implemented:

https://github.com/arduino/ArduinoCore-renesas/blob/fedf7896ed6c2e66d42ed5642198f5617a2daa55/cores/arduino/usb/SerialUSB.cpp#L31-L33

This can lead to unexpected behavior [in libraries that expect it](https://github.com/janelia-arduino/TMC2209/issues/62).

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in cores/arduino/usb/SerialUSB.cpp at the _SerialUSB::end function linked in the issue. Trace how SerialUSB is used and review the linked TMC2209 report to determine the expected end behavior. Done means the previously unimplemented function behaves correctly for libraries that call it.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
embedded-iot
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.