arduino / arduino/ArduinoCore-renesas

Device-specific .h files do not match Renesas/User's Manual

Open
#354 0 comments 0 reactions 0 assignees View on GitHub
type: imperfection
Dominant language
C
Stars
193
Forks
112
PR merge metrics
No merged PRs in 30d

Description

The header files (e.g. [`variants/UNOWIFIR4/includes/ra/fsp/src/bsp/cmsis/Device/RENESAS/Include/R7FA4M1AB.h`](https://github.com/arduino/ArduinoCore-renesas/blob/a430d9fbfcbea2ae293f842f211f1b5935ffdd90/variants/UNOWIFIR4/includes/ra/fsp/src/bsp/cmsis/Device/RENESAS/Include/R7FA4M1AB.h)) are out of date with the [Renesas repository](https://github.com/renesas/fsp) and are sometimes wrong.

For example, looking at the User's Manual "22.2.12 General PWM Timer Control Register (GTCR)" section, the bit offset for the TPCS field is 24. This matches the definition in the **Renesas** repo:

```cpp
#define R_GPT0_GTCR_TPCS_Pos (24UL) /*!< TPCS (Bit 24)
```

However, the code in this repo is off by one:

https://github.com/arduino/ArduinoCore-renesas/blob/a430d9fbfcbea2ae293f842f211f1b5935ffdd90/variants/UNOWIFIR4/includes/ra/fsp/src/bsp/cmsis/Device/RENESAS/Include/R7FA4M1AB.h#L14441

```cpp
#define R_GPT0_GTCR_TPCS_Pos (23UL) /*!< TPCS (Bit 23) */
```

Please update the device-specific headers in this repository to match the up to date Renesas headers.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with variants/UNOWIFIR4/includes/ra/fsp/src/bsp/cmsis/Device/RENESAS/Include/R7FA4M1AB.h and compare its register definitions with the corresponding headers in the Renesas fsp repository and the User's Manual. Update the device-specific headers so their definitions match the current Renesas headers, including the cited R_GPT0_GTCR_TPCS_Pos value, and verify that all affected headers are current.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
embedded-iot
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.