arduino / arduino/ArduinoCore-renesas

PR 204 (PWM with float parameters) confuses the compiler

Open
#273 1 comment 0 reactions 1 assignee Assigned to @maidnl View on GitHub
topic: code type: imperfection
Dominant language
C
Stars
193
Forks
112
PR merge metrics
No merged PRs in 30d

Description

https://github.com/arduino/ArduinoCore-renesas/pull/204 introduced an error in https://github.com/pschatzmann/arduino-audio-tools/blob/c88d3b9f132555ab7cd932a53744fa6c42aa8e0f/src/AudioPWM/PWMAudioRenesas.h#L90 (due to type confusion between int and float).

Proposed fix: change the signature of `begin(uint32_t, uint32_t, ...)` to `begin(int, int, ...)`

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.