arduino / arduino/ArduinoCore-mbed
Question on improving `arduino::WiFiClass::statusCallback`
- Dominant language
- C
- Stars
- 411
- Forks
- 225
- PR merge metrics
- No merged PRs in 30d
Description
Hi, I noticed this takes an `nsapi_event_t status` param but it is not used, why is this? Doesn't seem like this is needed here?
https://github.com/arduino/ArduinoCore-mbed/blob/ac7d14eb8404ad9c396eabc36a655c1183e8f3e4/libraries/WiFi/src/WiFi.cpp#L244-L251
Contributor guide
No contributing guide indexed for this repository
Research direction
Start at libraries/WiFi/src/WiFi.cpp around lines 244-251 and trace how statusCallback is declared and used. Determine whether the nsapi_event_t status parameter is intentionally retained; done means the rationale is documented or the callback interface and its uses are consistently updated if the parameter is unnecessary.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- arduino, cpp
- Domain
- embedded-iot, networking
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100