arduino / arduino/ArduinoCore-mbed

Support CDC_SEND_BREAK

Open
#695 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
411
Forks
225
PR merge metrics
No merged PRs in 30d

Description

When I try to transplant my code fron Due to Giga r1 Wifi, I found that the opertation `SetCommBreak` will always failed.
Then I check the source code, it seems that it is not supported yet:
(don't have `CDC_SEND_BREAK`)
https://github.com/arduino/ArduinoCore-mbed/blob/9795c3c22e009796d3f1a283fc6aa1b3a8575e43/cores/arduino/USB/USBCDC.cpp#L35-L37

https://github.com/arduino/ArduinoCore-sam/blob/790ff2c852bf159787a9966bddee4d9f55352d15/cores/arduino/USB/USBCore.h#L55-L58
![image](https://github.com/arduino/ArduinoCore-mbed/assets/18380374/9d75f026-600f-4f1a-9c88-ce53a9faa700)

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with cores/arduino/USB/USBCDC.cpp at the referenced CDC request definitions and compare the corresponding declarations in cores/arduino/USB/USBCore.h from ArduinoCore-sam. Trace how SetCommBreak is handled and verify that CDC_SEND_BREAK is supported without breaking the existing USB CDC behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
embedded-iot
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.