arduino / arduino/ArduinoCore-avr
In Arduino.h "byte" is typedef'd, but all prototypes except `makeword` use uint8_t, normalize `makeword`
Open
- Dominant language
- C
- Stars
- 1.5k
- Forks
- 1.1k
- PR merge metrics
- No merged PRs in 30d
Description
From the compiler's point of view, it's a non-issue, but for the code reader, it's confusing, not least because the inverse functions `lowByte` and `highByte` return type `uint8_t`, not `byte`.
Fixed by #414
Contributor guide
No contributing guide indexed for this repository
Research direction
Start in Arduino.h and inspect the makeword declaration alongside lowByte and highByte. Confirm the return type is consistent with the other prototypes; the work is done when makeword no longer uses byte and matches the stated uint8_t convention.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- embedded-iot
- Issue type
- Refactor
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 25/100