Core code produces warnings when compiling for ATtiny85
- Dominant language
- Java
- Stars
- 14.6k
- Forks
- 7k
- PR merge metrics
- No merged PRs in 30d
Description
I've got in **File > Preferences** under "Additional Boards Manager URLs" the link:
https://raw.githubusercontent.com/damellis/attiny/ide-1.6.x-boards-manager/package_damellis_attiny_index.json
Is it possible to correct the warnings in WInterrupts for ATtiny 25/45/85 and 24/44/84 ?
```
C:\Program Files (x86)\Arduino\hardware\arduino\avr\cores\arduino\WInterrupts.c: In function 'attachInterrupt':
C:\Program Files (x86)\Arduino\hardware\arduino\avr\cores\arduino\WInterrupts.c:198:8: warning: #warning attachInterrupt may need some more work for this cpu (case 1) [-Wcpp]
#warning attachInterrupt may need some more work for this cpu (case 1)
^~~~~~~
C:\Program Files (x86)\Arduino\hardware\arduino\avr\cores\arduino\WInterrupts.c: In function 'detachInterrupt':
C:\Program Files (x86)\Arduino\hardware\arduino\avr\cores\arduino\WInterrupts.c:312:8: warning: #warning detachInterrupt may need some more work for this cpu (case 1) [-Wcpp]
#warning detachInterrupt may need some more work for this cpu (case 1)
^~~~~~~
In file included from C:\Program Files (x86)\Arduino\hardware\arduino\avr\cores\arduino\WInterrupts.c:29:0:
C:\Program Files (x86)\Arduino\hardware\arduino\avr\cores\arduino\WInterrupts.c: In function 'INT1_vect':
C:\Program Files (x86)\Arduino\hardware\arduino\avr\cores\arduino\WInterrupts.c:373:15: warning: 'INT1_vect' appears to be a misspelled 'signal' handler, missing '__vector' prefix [-Wmisspelled-isr]
IMPLEMENT_ISR(INT1_vect, EXTERNAL_INT_1)
^
C:\Program Files (x86)\Arduino\hardware\arduino\avr\cores\arduino\WInterrupts.c:373:1: note: in expansion of macro 'IMPLEMENT_ISR'
IMPLEMENT_ISR(INT1_vect, EXTERNAL_INT_1)
^~~~~~~~~~~~~
In file included from C:\Program Files (x86)\Arduino\hardware\arduino\avr\cores\arduino\Tone.cpp:37:0:
C:\Program Files (x86)\Arduino\hardware\arduino\avr\cores\arduino\Tone.cpp: In function 'void TIMER2_COMPA_vect()':
C:\Program Files (x86)\Arduino\hardware\arduino\avr\cores\arduino\Tone.cpp:538:5: warning: 'TIMER2_COMPA_vect' appears to be a misspelled 'signal' handler, missing '__vector' prefix [-Wmisspelled-isr]
ISR(TIMER2_COMPA_vect)
^
In function 'INT1_vect':
C:\Program Files (x86)\Arduino\hardware\arduino\avr\cores\arduino\WInterrupts.c:373:1: warning: 'INT1_vect' appears to be a misspelled 'signal' handler, missing '__vector' prefix [-Wmisspelled-isr]
IMPLEMENT_ISR(INT1_vect, EXTERNAL_INT_1)
^
In function 'INT1_vect':
C:\Program Files (x86)\Arduino\hardware\arduino\avr\cores\arduino\WInterrupts.c:373:1: warning: 'INT1_vect' appears to be a misspelled 'signal' handler, missing '__vector' prefix [-Wmisspelled-isr]
IMPLEMENT_ISR(INT1_vect, EXTERNAL_INT_1)
^
```
Contributor guide
Research direction
Reproduce a build for an ATtiny25/45/85 or 24/44/84 using the linked board package, then inspect the warning sites in hardware/arduino/avr/cores/arduino/WInterrupts.c and Tone.cpp. Compare the interrupt handling with the target's available vectors; done means the reported compile warnings are resolved without breaking the affected interrupt and tone functionality.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- embedded-iot
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100