ardatan / ardatan/graphql-tools

handle error from custom loader

Open
#4,612 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
5.4k
Forks
830
Avg merge
10h 59m
Merged PRs (30d)
45

Description

Currently, an error for a custom loader is swallowed, leading to a bad DX:

https://github.com/ardatan/graphql-tools/blob/53292e675ec6ec11f5c7b9d244898340cf7e109e/packages/load/src/utils/custom-loader.ts#L18

_____

originally raised in https://github.com/dotansimha/graphql-code-generator/discussions/7928#discussioncomment-3285607

Contributor guide

Open the contributing guide

Research direction

Start at packages/load/src/utils/custom-loader.ts around line 18 and trace how errors from a custom loader are handled. Review the linked discussion for the reported behavior; done means the custom-loader error is surfaced instead of swallowed, with the existing package behavior still working.

Written by the indexing model from the issue text.

Assessment

Tech stack
graphql, typescript
Domain
backend-api-design, tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.