arcus-azure / arcus-azure/arcus.webapi

Cleanup custom dimensions in request-logging

Open
#478 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
21
Forks
11
PR merge metrics
No merged PRs in 30d

Description

When using RequestTracking in Arcus.WebApi, we log an obsolete / unused dimension. I believe this is an artefact of the past where we used the `Body` dimension to log the request-body. This has been changed later when we also made it possible to log the response-body.
I think we're now in a stage where we can remove the logging of the `Body` dimension

![Image](https://github.com/user-attachments/assets/631e0c6c-872d-4b05-9db6-e161c99b7bdf)

Next to that, I also see that we log a dimension called `Request` which looks like it contains details about the HTTP Operation, the URL, the Request- and Response body, but also the `Body` dimension

![Image](https://github.com/user-attachments/assets/f3faf685-58d7-47ee-86eb-47896729fa88)

I believe we can remove this one as well ?

Contributor guide

Open the contributing guide

Research direction

Start by locating the RequestTracking request-logging implementation in Arcus.WebApi and trace where the Body and Request dimensions are added. Check the existing logging tests, if present, and confirm that both obsolete dimensions are no longer emitted without removing the request- or response-body logging that replaced them.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
observability
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.