archethic-foundation / archethic-foundation/archethic-node

P2P NetworkView hash may not be usefull anymore

Open
#1,664 0 comments 0 reactions 0 assignees View on GitHub
feature
Dominant language
Elixir
Stars
82
Forks
24
PR merge metrics
No merged PRs in 30d

Description

### Is your feature request related to a problem?

The p2p network view hash aims to ensure the validation nodes have the same view of the p2p nodes, mainly to ensure the last public keys are the same.
But since https://github.com/archethic-foundation/archethic-node/pull/1642/ the validation nodes election algorithm uses the first public key of the nodes to compute the election, therefore there is no more needs to ensure the validation nodes have the same last public key for each nodes.

### Describe the solution you'd like

We could remove the p2p network view hash from the network view to keep only the network chains view.

### Additional context

_No response_

### Epic

_No response_

Contributor guide

Open the contributing guide

Research direction

Start by reading pull request 1642 and tracing where the P2P network view hash is built, exchanged, and validated. Check the related tests if they are found during that trace. Done means the P2P hash is removed while the network chains view remains intact and its tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
elixir
Domain
blockchain, distributed-systems
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.