archethic-foundation / archethic-foundation/archethic-node

Incorrect handling of not found proof of work

Open
#1,539 0 comments 0 reactions 1 assignee Claimed by @bchamagne View on GitHub
bug mining
Dominant language
Elixir
Stars
82
Forks
24
PR merge metrics
No merged PRs in 30d

Description

### Describe the problem you discovered

When an incoming transaction has an invalid origin signature, the coordinator node does not retrieve the proof of work.
The proof of work returns an empty string. Then the validation stamp is serialized replacing the empty string with `<<0::32>>`.
Then the cross validators compare the proof of work they found (empty string) with the one in the validation stamp (`<<0::32>>`) which does not match while all nodes did not found the POW.
This result into a wrong consensus not reach error

### Describe the solution you'd like

Define a better workflow for invalid proof of work

### Epic

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.