aquasecurity / aquasecurity/cloudsploit
skipRegions parameter in collectors or engine.js is not taking effect
- Dominant language
- JavaScript
- Stars
- 3.8k
- Forks
- 751
- Avg merge
- 11d 9h
- Merged PRs (30d)
- 3
Description
Hi,
As per documentation we can skipRegions by specifying it in array inside export.js. I did not find any option inside export.js however found it inside engine.js & collector.js. Tried adding values inside skipRegions but its not working.
Am I missing or misunderstood something ?
Appreciate your help.
Settings done as below by skipping 'us-east-2':
var serviceProviders = {
aws : {
name: "aws",
collector: require('./collectors/aws/collector.js'),
config: AWSConfig,
apiCalls: [],
skip_Regions: ['us-east-2'] // Add any regions you wish to skip here. Ex: 'us-east-2'
},
However in results output still checks for 'us-east-2':
{
"plugin": "cloudtrailFileValidation",
"category": "CloudTrail",
"title": "CloudTrail File Validation",
"resource": "N/A",
"region": "us-east-2",
"status": "FAIL",
"message": "CloudTrail is not enabled"
},
Contributor guide
Research direction
Start by comparing the skip_Regions setting shown in export.js with the skipRegions handling in engine.js and collectors/aws/collector.js. Reproduce the AWS scan with us-east-2 configured, trace where regions are selected, and confirm that the completed results no longer include that region.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- aws, javascript
- Domain
- cloud, security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100