appwrite / appwrite/dynamic-links

🐛 Bug Report: target vs targets

Open
#5 3 comments 0 reactions 1 assignee Claimed by @stnguyen90 View on GitHub
bug good first issue
Dominant language
HTML
Stars
105
Forks
15
PR merge metrics
No merged PRs in 30d

Description

### 👟 Reproduction steps

In `main.js` shouldn't line 60:

```js
.join(target.fallback ?? target.default ?? '')
```

be `targets` instead of `target`?

I tried to create types because I am using TypeScript in my appwrite functions. My type definitions where:

```ts
interface TargetPrefs {
appName?: string;
appPath?: string;
appPackage?: string;
fallback?: string;
}

interface Targets {
[platform: string]: string | TargetPrefs;
}

interface PathConfig {
path: string;
targets: Targets;
}
```

### 👍 Expected behavior

The platform definitions in the CONFIG examples do not contain an example where a target/platform contains a `default` property.

### 👎 Actual Behavior

Only targets have a property `default` which might be accessible.

### 🎲 Appwrite version

Version 1.4.x

### 💻 Operating system

Linux

### 🧱 Your Environment

appwrite 1.4.3

nodeJS using TypeScript

### 👀 Have you spent some time to check if this issue has been raised before?

- [X] I checked and didn't find similar issue

### 🏢 Have you read the Code of Conduct?

- [X] I have read the [Code of Conduct](https://github.com/appwrite/.github/blob/main/CODE_OF_CONDUCT.md)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.