appsmithorg / appsmithorg/appsmith
[Task]: Datasource creation method is not standard (Lacks TS definitions)
- Dominant language
- TypeScript
- Stars
- 40.9k
- Forks
- 4.8k
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 45
Description
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current Behavior
The way a new action is created, there are some places that use different arguments for the same function. The issue comes up due to the lack of TS definition of the `action.datasource` object. It sometimes has a pluginId in it and sometimes doesn't. At the time of reporting this issue, there are 2.5K+ actions that do not have the `action.datasource.pluginid` key not set. Since the new actions are created from FE side, a fix here would be to add proper TS definitions that either make sure that pluginID is needed or not.
### Steps To Reproduce
Not sure how to reproduce it yet. Refer to issue #10286 and [PR](https://github.com/appsmithorg/appsmith/pull/10290) for more details around this issue.
### Environment
Release
### Version
Cloud
Contributor guide
Assessment
This issue has not been assessed yet.