approvals / approvals/Approvals.NodeJS
Cannot read property 'blockUntilReporterExits' of undefined
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 125
- Forks
- 46
- Avg merge
- 2m
- Merged PRs (30d)
- 16
Description
I receive this error when I follow the mocha example. I have made a PR to solve the problem, but I believe the source of the issue is approvals\lib\Providers\BeforeEachVerifierBase.js It's call to FileApprover.verify(namer, writer, reporterFactory); doesn't pass in any options and GenericDiffReporterBase.report (and other reporters) are written as if it did.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in approvals\lib\Providers\BeforeEachVerifierBase.js and trace the FileApprover.verify(namer, writer, reporterFactory) call. Then inspect GenericDiffReporterBase.report and the other reporters to confirm their options expectations; done means the Mocha example runs without the blockUntilReporterExits error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- nodejs, typescript
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100