approvals / approvals/Approvals.NodeJS
failOnLineEndingDifferences not working
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 125
- Forks
- 46
- Avg merge
- 2m
- Merged PRs (30d)
- 16
Description
I'm on v3.0.5 and approvals keeps failing for line ending differences. I've done a byte by byte comparison and confirmed it's just a difference of line endings. The reporter does not affect this, does it? I'm using vscode as the reporter.
I'm using verifyAsJson
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the verifyAsJson entry point and reproduce the reported behavior with the VS Code reporter and failOnLineEndingDifferences enabled. Done means line-ending-only differences are handled as expected by that option, with a regression test covering the case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100