approvals / approvals/Approvals.NodeJS
Allow specifying a file extension from options override (HTML for instance, helpful to preview in the browser)
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 125
- Forks
- 46
- Avg merge
- 2m
- Merged PRs (30d)
- 16
Description
I am unable to use a different extension for the approved file name. Right now, I see the verifyAndScrub function has a namer var namer = new ManualNamer(dirName, testName);.
I followed the call stack and couldn't spot a place where I can specify a different extension for my approved file. I am new to JS, please let me know if I'm missing something here.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the verifyAndScrub entry point and follow how ManualNamer receives the directory and test name, then trace where options overrides are handled. The work is done when an override can select a file extension such as HTML and the approved file is created with that extension; check the existing tests for the appropriate coverage.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- nodejs, typescript
- Domain
- testing
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100