approvals / approvals/Approvals.NodeJS

Approvals.NodeJS pulls `"edge"`, `"edge-cs"`, and `"nan"` dependencies on Windows

Open
#111 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
125
Forks
46
Avg merge
2m
Merged PRs (30d)
16

Description

We are using Approvals.NodeJS 4.0.0-beta.1 in our project, however the npm package pulls in the above mentioned dependencies on Windows, but not on Mac. Which in-turn modifies the package-lock.json file. It affects how developers collaborate in the project. Curious to know how to work with this issue. Thanks and any help is much appreciated.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the package-lock.json produced on Windows and Mac for Approvals.NodeJS 4.0.0-beta.1, focusing on the edge, edge-cs, and nan dependencies. Trace the npm package dependency metadata that causes the platform difference; done means the platform-specific lockfile change is eliminated or the supported workaround is clearly documented.

Written by the indexing model from the issue text.

Assessment

Tech stack
nodejs, typescript
Domain
testing, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.