approvals / approvals/ApprovalTests.cpp

_mkdir fails when asked to create more than one directory

Open
#226 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C++
Stars
339
Forks
55
PR merge metrics
No merged PRs in 30d

Description

On windows, _mkdir is used to create directories. But _mkdir can only create one subdir at a time.
If a TemplatedCustomNamer needs to create several new paths (existing: "d:\whatever", needed: "d:\whatever\tests\mytest\approval"), it will fail with an exception.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate TemplatedCustomNamer and the Windows _mkdir usage, then reproduce the failure when a nested path such as d:\whatever\tests\mytest\approval\ must be created. The work is done when creating several missing directory levels succeeds without an exception on Windows.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
testing
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.