approvals / approvals/ApprovalTests.cpp
`verifyAll` won't compile with some c++20 ranges view.
Open
Nobody has claimed this yet.
bug
on_hold
- Dominant language
- C++
- Stars
- 339
- Forks
- 55
- PR merge metrics
- No merged PRs in 30d
Description
The function verifyAll assumes that the Container has an associated type name value_type. This is not true for all views. The issue show up on "approvalTests.hpp:1656" for version 10.8.0.
[&](typename Container::value_type e, std::ostream& s) {
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at approvalTests.hpp:1656 and trace verifyAll's use of Container::value_type. Reproduce the compilation failure with a C++20 ranges view, then confirm that verifyAll compiles for views without that associated type and that the existing testing behavior remains intact.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100