approvals / approvals/ApprovalTests.Ruby
rspec extension specs don't clean up after themselves
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 231
- Forks
- 45
- PR merge metrics
- No merged PRs in 30d
Description
The tests in spec/extensions/rspec_approvals_spec.rb lines 64 - 78 leave the *received.txt files even when the tests pass. They also add entries in the .approvals file.
This gets in the way when there are other failures and you're using the command line tool to step through each of the diffs one at a time.
$ cat .approvals
spec/fixtures/approvals/verifies_a_failure.approved.txt spec/fixtures/approvals/verifies_a_failure.received.txt
spec/fixtures/approvals/verifies_a_failure_diff.approved.txt spec/fixtures/approvals/verifies_a_failure_diff.received.txt
spec/fixtures/approvals/verifies_directory/a_failure.approved.txt spec/fixtures/approvals/verifies_directory/a_failure.received.txt
spec/fixtures/approvals/verifies_directory/a_failure_diff.approved.txt spec/fixtures/approvals/verifies_directory/a_failure_diff.received.txt
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with spec/extensions/rspec_approvals_spec.rb, lines 64–78, and run the extension specs to reproduce the leftover files and .approvals entries. Inspect how those examples create received.txt files and update .approvals. Done means passing tests leave neither those received files nor unwanted .approvals entries behind.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100