approvals / approvals/ApprovalTests.Ruby
Html approver mangles html with boolean attributes
Open
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 231
- Forks
- 45
- PR merge metrics
- No merged PRs in 30d
Description
the following (valid) html:
<!DOCTYPE html>
<html>
<title>Hoi</title>
<script async defer src=\"http://foo.com/bar.js\"></script>
<h1>yo</h1>
becomes this:
<!DOCTYPE html>
<html xmlns="http://www.w3.org/1999/xhtml"><script>window.FactlinkProxiedUri = "http://www.example.org/foo?bar=baz";</script><script></script>defer
src="http://localhost:8000/lib/dist/factlink_loader.js?o=proxy"
onload="__internalFactlinkState('proxyLoaded')"
></html>
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue provides a minimal HTML reproduction but names no file or test. Locate the HTML approver entry point, reproduce the transformation with the supplied snippet, and inspect how boolean attributes are processed. Done means valid HTML remains intact, including async and defer attributes, script content, and document structure.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- html, ruby
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100