approvals / approvals/ApprovalTests.Ruby

A hash ( # ) should not be stripped from approval name

Open
#27 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
231
Forks
45
PR merge metrics
No merged PRs in 30d

Description

I noticed I test a lot of controller actions, so my names tend to be something like

"blogposts#show.json should stay the same"

I think we can do better handling of the # than stripping it. (this would mean a breaking change though, but I think this is still okay, as long as we add it to the changelog)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Start by locating the approval-name normalization and its existing tests, then use the controller-style name "blogposts#show.json" to define the expected behavior; done should include regression coverage and a changelog entry for the breaking change.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
testing-qa
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.