approvals / approvals/ApprovalTests.Ruby

Some example metadata is wrong/missing (RSpec integration)

Open
#1 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Ruby
Stars
231
Forks
45
PR merge metrics
No merged PRs in 30d

Description

A bunch of the metadata on the example points to the DSL module rather than the place where the verify is being called, since specify() is being called in the DSL module. I think it should be possible to bind the call to specify to the callers context.

Some of the issues this causes are:

  • The approvals don't register :filtered => true, e.g. if you try to run just certain examples or groups.
  • The formatter for an example group points to the DSL file rather than the spec file

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by examining the RSpec integration around specify() in the DSL module and how verify is called. Trace how example metadata is assigned, then confirm that approvals expose filtered=true when appropriate and that example-group formatters point to the spec file rather than the DSL file.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.