approvals / approvals/ApprovalTests.Python
Look for config in parent directories
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 212
- Forks
- 56
- Avg merge
- 1m
- Merged PRs (30d)
- 1
Description
In many testing frameworks, it is common to an entire directory tree of tests. With the current implementation of get_config, we need to have an approvaltests_config.json file in every directory in the hierarchy. This is annoying and error prone.
I think we should make it search all parent directories until it finds a config file. That way, a single file at the top-level of the tests will be sufficient.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the get_config implementation and review how it currently resolves approvaltests_config.json. Verify the behavior with the existing configuration-related tests, then ensure a config in a parent directory is found for nested tests and that the search stops at the first applicable file.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing-qa
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100