approvals / approvals/ApprovalTests.Python
`.with_scrubber(replace = true)`
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 212
- Forks
- 56
- Avg merge
- 1m
- Merged PRs (30d)
- 1
Description
People find with_scrubber/add_scrubber confusing - they don't realize that with overwrites existing scrubbers and that they need to use add to avoid that and chain them instead.
The proposal is to change with to always add, unless an optional argument replace = True is passed.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the with_scrubber and add_scrubber implementations and their tests. Read how existing scrubbers are stored and chained, then update the behavior so with_scrubber adds by default and replaces only when replace=True. Done means the documented distinction is reflected in passing tests for both paths.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing-qa
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100