approvals / approvals/ApprovalTests.LabVIEW

Marginal differences shouldn't fail the test (there should be an option for this - sometimes a marginal failure is important)

Open
#4 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
LabVIEW
Stars
5
Forks
3
PR merge metrics
No merged PRs in 30d

Description

Caraya supports a margin of error when comparing floating point numbers (as 10.0 != 10.0 exactly)

I found a similar issue when generating png images and trying to compare them. The two attached images were generated by exactly the same configuration script and look identical, but not when you put them through a compare tool - however for my purposes they're close enough (its the ends of the error bars that are 1 or 2 pixels different).

Its not urgent as the work around is to compare the configuration script, which is generated from a list of parameters - and that's what I'm really trying test
Test error-bar override test error bar base json formatter approved
Test error-bar override test error bar base json formatter received

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the image-comparison path and the existing floating-point margin-of-error behavior; the issue does not name specific files or tests. Define how an optional image tolerance should work while preserving strict comparisons by default, then add coverage showing that small pixel differences can pass and meaningful differences still fail.

Written by the indexing model from the issue text.

Assessment

Domain
testing
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.