approvals / approvals/ApprovalTests.Java
Architectural Problem in namers
Open
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 387
- Forks
- 85
- Avg merge
- 4m
- Merged PRs (30d)
- 10
Description
The namers in Python have two simple functions, Java has at least 4 we need to simplify that.
See: https://github.com/approvals/ApprovalTests.Python/blob/main/approvaltests/core/namer.py
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the referenced Python namer implementation in approvaltests/core/namer.py, then inspect the Java namer classes and compare their public functions. Determine how the Java design can be simplified to match the stated Python approach; done means the Java namers no longer require the current four-or-more-function structure.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, python
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100