appleple / appleple/smartblock
Image Extension Key Prop Error & Link Error
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 318
- Forks
- 26
- Avg merge
- 3m
- Merged PRs (30d)
- 11
Description
Hello!
Thank you for this great editor. Today, I was testing the Extensions and I encountered two errors,
- First error occurred when I added the
new Image({})extension which says an Element needs a key prop (for which I'm guessing the.smartblock-menuelement doesn't have a key prop).
- Second Error is when I select a node and add want to add a link to it. Like this:
Which gives the following error in the console:
But the link error occurs only when a part of block is selected not when the whole block is selected.
Any idea about these?
Thanks in advance.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce both cases from the issue: add the new Image({}) extension and select part of a block before adding a link. Inspect the Extensions path, the .smartblock-menu element, and the link-selection path; done means neither scenario reports a console error or key-prop warning.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100