appleple / appleple/SmartPhoto
If images fail to load and image viewer is open, overlay is not removed from DOM when the viewer is closed
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 895
- Forks
- 57
- Avg merge
- 1m
- Merged PRs (30d)
- 4
Description
If the image is not available, and you attempt to open the image viewer, the viewer will display a progress/loading spinner. Closing the viewer using the top "X" close button, will successfully close the viewer, however there will be an invisible overlay left on top of the DOM preventing interaction with the application.
The console reveals a NPE on the attempt to close the viewer:
Uncaught (in promise) TypeError: Cannot read property 'style' of null
at smartphoto.min.js:104
at new Promise ()
at e.value (smartphoto.min.js:104)
at e.value (smartphoto.min.js:104)
at smartphoto.min.js:103
at HTMLDivElement. (smartphoto.min.js:103)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the failed-image case with the viewer open, then inspect the close path indicated by smartphoto.min.js:103-104 and the reported null style access. Verify that closing with the top X removes the overlay from the DOM and no longer raises the TypeError.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100