appleboy / appleboy/react-recaptcha

Pre commit broken on Windows.

Open
#219 3 comments 0 reactions 1 assignee Claimed by @appleboy View on GitHub
enhancement
Dominant language
JavaScript
Stars
643
Forks
96
PR merge metrics
No merged PRs in 30d

Description

I'm trying to create a few pull requests but the pre-commit hook is broken for me. I looked in the package.json and I see the pre-commit runs lint and test. I ran those commands individually and they both pass but I can't commit with git in this repo. Below is the results of running lint and test then trying to commit. The very bottom of the image is the error message I am receiving.

![pre-commit-hook](https://user-images.githubusercontent.com/12447474/35163838-a8348af4-fd0d-11e7-94a9-5fdc84aa9039.png)

It appears that pre-commit is broken on Windows: https://github.com/observing/pre-commit/issues/102

Can we remove the pre-commit hook and let CI take care of that? Because this repo is mostly unusable on Windows in it's current state.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.