appleboy / appleboy/gorush

CollapseID and CollapseKey missing in NotificationRequest proto

Open
#710 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
8.8k
Forks
887
PR merge metrics
No merged PRs in 30d

Description

Following properties are missing from the NotificationRequest message in `gorush.proto`:

1. CollapseKey - Only for Android
2. CollapseID - Only for IOS

Screenshot 2023-01-09 at 11 11 04 PM

Above mentioned properties are working fine if i am sending http request. But as these are missing in proto defination, so i am not able to use them with GRPC

Contributor guide

No contributing guide indexed for this repository

Research direction

Open gorush.proto and locate the NotificationRequest message, then inspect how its existing fields support the HTTP notification request. Add support for the Android CollapseKey and iOS CollapseID fields in the gRPC-facing definition; done means both properties are available through gRPC as they are through HTTP.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, go, grpc, ios
Domain
api, backend-api-design
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.