Huawei "SendMessage" result processing
- Dominant language
- Go
- Stars
- 8.8k
- Forks
- 887
- PR merge metrics
- No merged PRs in 30d
Description
There is no "resp.Logs" append code in "notification_hms.go" file as "notification_fcm.go". So, if there is a failure, "FeedbackURL" is not called for informing that error in "notification.go"
I propose to add following lines where "res.Code" is checked for failure, in line 214, "notification_hms.go".
**errLog := logPush(cfg, core.FailedPush, req.Tokens[0], req, errors.New(res.Code + "-" + res.Msg))
resp.Logs = append(resp.Logs, errLog)**
Contributor guide
No contributing guide indexed for this repository
Research direction
Inspect notification_hms.go around line 214 where res.Code is checked for failure, then compare the response-log handling in notification_fcm.go. Trace how notification.go uses the logs to call FeedbackURL, and confirm that Huawei failures are recorded there as well.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100