appleboy / appleboy/drone-ssh

Can't use comma in script/commands

Open
#60 8 comments 1 reaction 0 assignees View on GitHub
Dominant language
Go
Stars
314
Forks
79
Avg merge
3m
Merged PRs (30d)
1

Description

Dunno is it correct or not, but this line in my script section:
```
script:
- echo "aaa,aaa,aaa"
```
always transforms in:
```
echo "aaa
aaa
aaa"
```
Guessing because of StringSlice call in https://github.com/appleboy/drone-ssh/blob/master/main.go#L171

But i need these commas. They must remain. Can i escape commas? Any solution?

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in main.go around line 171, where the issue identifies the StringSlice call. Reproduce the transformation with the provided script command containing commas, then trace how the command is split. Done means commas remain intact in the resulting remote command, with a regression test covering the example.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli, networking
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.