apple / apple/swift-nio-ssh

NIOSSHClientUserAuthenticationDelegate Improvement Request: Result Reporting

Open
#65 2 comments 1 reaction 0 assignees View on GitHub
kind/enhancement
Dominant language
Swift
Stars
515
Forks
85
PR merge metrics
No merged PRs in 30d

Description

The `NIOSSHClientUserAuthenticationDelegate` provides a single method, `nextAuthenticationRequest`, for providing offers for authenticating with a remote host. In the golden path, an auth request is successful and everyone is happy. However, in situations where the request fails, either because of incorrect credentials or an unexpected failure on the remote end, it would be useful for the delegate to receive a notification to that effect. As things stand now, the only way to know an offer fails is if the method is called again. That type of inference is something I'd rather not rely upon.

In my research of this repository, I came across `NIOSSHUserAuthenticationOutcome`; I wonder if using that here would be helpful?

Contributor guide

Open the contributing guide

Research direction

Start by tracing NIOSSHClientUserAuthenticationDelegate.nextAuthenticationRequest and reviewing NIOSSHUserAuthenticationOutcome to understand the existing authentication flow and available result information. Define the failure-notification semantics and the tests needed to show that incorrect credentials and remote failures are reported explicitly rather than inferred from another request.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
networking
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.