apple / apple/swift-nio-ssh

When a Channel of type tcpip-forward is closed, it does not emit the closure request

Open
#16 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Swift
Stars
515
Forks
85
PR merge metrics
No merged PRs in 30d

Description

I'd suggest the channel to keep track of the channel being explicitly closed by the user or third party. When it _is_ explicitly closed, I'd send the "cancel-tcpip-forward" global request as described on [RFC 4254 page 17](https://ietf.org/rfc/rfc4254.txt). This way, the user does not need to concern itself with protocol specific knowledge. This allows libraries to wrap a channel without requiring awareness of the SSH protocol.

Contributor guide

Open the contributing guide

Research direction

Start by locating the tcpip-forward channel close handling and compare its behavior with RFC 4254 page 17. Trace how explicit closure by the user or third party is represented, then verify that the completed behavior emits the cancel-tcpip-forward global request without requiring protocol knowledge from the caller.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.