apple / apple/swift-nio-http2

NIOHTTP2ServerConnectionManagementHandler doesn't handle input closed event

Open
#558 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Swift
Stars
503
Forks
103
Avg merge
18h 8m
Merged PRs (30d)
4

Description

I'm looking into replacing the Hummingbird `HTTP2ServerConnectionManager` with the one that has been added to `swift-no-http2`. Both of them are based off the gRPC version so I thought I might be able to swap one out for the other. Unfortunately this isn't the case. It appears the NIO version does not handle inputClosed events and will leave the HTTP2 channel dangling, if a client closes the connection. Is it expected that these will be handled elsewhere?

Contributor guide

Open the contributing guide

Research direction

Start by locating NIOHTTP2ServerConnectionManagementHandler and tracing how an inputClosed event is propagated when an HTTP/2 client closes its connection. Reproduce the client-close case and verify that the channel is no longer left dangling; the issue does not name a specific test or file.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.